ISPN-14620 ZREM, ZREMRANGEBYLEX, ZREMRANGEBYSCORE, ZREMRANGEBYRANK #11213
Conversation
| * @return the number of removed elements | ||
| */ | ||
| public CompletionStage<Long> removeAll(K key, V min, boolean includeMin, V max, boolean includeMax) { | ||
| return removeAll(key, min, includeMin, max, includeMax, LEX); |
There was a problem hiding this comment.
From the tests, null values for min/max mean some sort of "unbounded" remove? Maybe we should call that out in the method Java doc. Otherwise, mistakenly passing a null would remove the elements.
There was a problem hiding this comment.
Looking at the RESP side, it seems the values are supposed to be non-null. Do we include a check here?
There was a problem hiding this comment.
values are non null, but can be -inf +inf or + -. in these cases, we provide null values to remove from head to tail
There was a problem hiding this comment.
I agree the api in the multimap is not awesome, but it's an implementation api, not public one. if we promote this apis, we need to come into what do we really want to support from infinispan hotrod
| * The number of members removed from the sorted set, not including non-existing members. | ||
| * | ||
| * @since 15.0 | ||
| * @see <a href="https://redis.io/commands/zmscore/">Redis Documentation</a> |
multimap/src/main/java/org/infinispan/multimap/impl/EmbeddedMultimapSortedSetCache.java
Show resolved
Hide resolved
multimap/src/main/java/org/infinispan/multimap/impl/EmbeddedMultimapSortedSetCache.java
Show resolved
Hide resolved
karesti
force-pushed
the
ISPN-14620-ZREM-Commands
branch
from
c041852
to
d5fddf9
Compare
karesti
force-pushed
the
ISPN-14620-ZREM-Commands
branch
from
d5fddf9
to
af9c8bb
Compare
|
@jabolina I fixed the ZREM and added the null parameters explanation |
|
Thanks, @karesti! |
https://issues.redhat.com/browse/ISPN-14620