ISPN-15212 TOUCH #11366
Merged
ISPN-15212 TOUCH #11366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
approved these changes
Oct 6, 2023
|
Thanks, @karesti! |
wburns
reviewed
Oct 9, 2023
|
|
||
| CompletableFuture<Long> totalTouchCount = CompletableFutures.sequence( | ||
| arguments.stream() | ||
| .map(key -> (CompletableFuture<Boolean>) handler.cache().touch(key, true)) |
There was a problem hiding this comment.
Do we want to touch even if it is max idle expired?
There was a problem hiding this comment.
The default behavior should be not to touch a key if it is already max expired. The only reason it is an option is for when a key is read on a different node before when it wasn't expired.
server/resp/src/main/java/org/infinispan/server/resp/commands/generic/TOUCH.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-15212