ISPN-15239 HotRod client repeatedly retries iteration operation again… #11422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
added
the
14.0.x
jabolina
commented
Oct 24, 2023
| @@ -112,7 +113,7 @@ protected long handleNextResponse(IterationNextResponse<K, E> nextResponse, Map. | |||
|
|
|||
| @Override | |||
| protected void handleThrowableInResponse(Throwable t, Map.Entry<SocketAddress, IntSet> target) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException || t instanceof ConnectException) { | |||
There was a problem hiding this comment.
Wondering if it needs all of:
There was a problem hiding this comment.
Hrmm, only ConnectException would be better if it is suitable.
wburns
reviewed
Oct 24, 2023
| @@ -112,7 +113,7 @@ protected long handleNextResponse(IterationNextResponse<K, E> nextResponse, Map. | |||
|
|
|||
| @Override | |||
| protected void handleThrowableInResponse(Throwable t, Map.Entry<SocketAddress, IntSet> target) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException || t instanceof ConnectException) { | |||
There was a problem hiding this comment.
Hrmm, only ConnectException would be better if it is suitable.
| @@ -112,7 +113,7 @@ protected long handleNextResponse(IterationNextResponse<K, E> nextResponse, Map. | |||
|
|
|||
| @Override | |||
| protected void handleThrowableInResponse(Throwable t, Map.Entry<SocketAddress, IntSet> target) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException) { | |||
| if (t instanceof TransportException || t instanceof RemoteIllegalLifecycleStateException || t instanceof ConnectException) { | |||
There was a problem hiding this comment.
We also need to add this to the hotrod module as well.
…st failed server after removal from topology
|
Updated the hotrod module. |
|
Integrated into main, thanks @jabolina ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st failed server after removal from topology
https://issues.redhat.com/browse/ISPN-15239
Looking at the logs, the iteration operation starts and calculates the segment owners, and then the topology updates. So, I updated the exception handling part.