ISPN-15299 PutAll during rebalance can get a ClassCastException #11467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wburns
added
the
14.0.x
wburns
commented
Nov 7, 2023
| currentStage = entryFactory.wrapEntryForWriting(ctx, key, keyPartitioner.getSegment(key), | ||
| ignoreOwnership || canReadKey(key), command.loadType() != VisitableCommand.LoadType.DONT_LOAD, currentStage); | ||
| currentStage = entryFactory.wrapEntryForWriting(ctx, key, segment, | ||
| ignoreOwnership || canReadSegment(segment) || needsWriteKeyForSegment(segment), command.loadType() != VisitableCommand.LoadType.DONT_LOAD, currentStage); |
There was a problem hiding this comment.
This is the actual fix as we now always wrap the entry in the context as an MVCCEntry which is required by the CallInterceptor for the PutAllCommand.
wburns
force-pushed
the
ISPN-15299_putall_CCE
branch
from
0fb3a78
to
45c6669
Compare
|
superseded by #11469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-15299
https://issues.redhat.com/browse/ISPN-15300