Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.x] ISPN-15309 Hot Rod client should use server key media-type to route r… #11503

Merged
merged 1 commit into from Dec 21, 2023

Conversation

github-actions[bot]
Copy link

Backport: #11480

…equest

https://issues.redhat.com/browse/ISPN-15309

  • This changes the client to serialize again if the server media type does not match the client configuration.
  • This fixes the iterator to convert the received key properly.

Basically, I made some changes to the DataFormat to keep track of the server's media type. Later, we decide whether to use the server's type when hashing the key to get the segment. In cases where the media types match, there is no need for this encoding.

@ryanemerson
Copy link
Contributor

@jabolina A manual backport is required:

[2023-12-06T03:53:41.136Z] 22:53:40.539 [ERROR] COMPILATION ERROR : 
[2023-12-06T03:53:41.136Z] 22:53:40.539 [INFO] -------------------------------------------------------------
[2023-12-06T03:53:41.136Z] 22:53:40.539 [ERROR] /home/infinispan/workspace/Infinispan_PR-11503/client/hotrod-client/src/test/java/org/infinispan/client/hotrod/hash/ConsistentHashTest.java:[104,62] error: incompatible types: MediaType cannot be converted to String
[2023-12-06T03:53:41.136Z] 22:53:40.539 [ERROR] /home/infinispan/workspace/Infinispan_PR-11503/client/hotrod-client/src/test/java/org/infinispan/client/hotrod/impl/iteration/MediaTypeMultiServerRemoteIteratorTest.java:[31,58] error: incompatible types: MediaType cannot be converted to String
[2023-12-06T03:53:41.136Z] 22:53:40.539 [INFO] 2 errors 

…equest

* This changes the client to serialize again in case the server
  media-type does not match the client configuration.
* This fixes the iterator to properly convert the received key.
@jabolina
Copy link
Member

Updated.

@wburns wburns merged commit 0039a65 into 14.0.x Dec 21, 2023
2 of 3 checks passed
@wburns
Copy link
Member

wburns commented Dec 21, 2023

Integrated into 14.0.x, thanks @jabolina !

@github-actions github-actions bot deleted the bp-14.0.x-a1fa463 branch December 21, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants