Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-15401 Remove worker-threads section from tuning guide #11622

Merged
merged 1 commit into from
Dec 22, 2023
Merged

ISPN-15401 Remove worker-threads section from tuning guide #11622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions documentation/src/main/asciidoc/topics/ref_performance_tuning.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,6 @@ The recommended values are:
* send window size - 640 KB
* receive window size - 25 MB

== Number of threads for Hot Rod connectors

The Hot Rod connector for {brandname} server uses worker threads that are
activated by clients requests. It is important to match the number of worker
threads to the number of concurrent client requests:

[source,xml,options="nowrap",subs=attributes+]
.Hot Rod Server worker thread pool size
----
include::xml/hotrod_worker_threads.xml[]
----

== SSL provider

{brandname} server will automatically use the native implementation of the OpenSSL libraries on supported platforms to
Expand Down
9 changes: 0 additions & 9 deletions documentation/src/main/asciidoc/topics/xml/hotrod_worker_threads.xml
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions ...d/src/main/java/org/infinispan/server/hotrod/configuration/HotRodServerConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ public class HotRodServerConfiguration extends ProtocolServerConfiguration<HotRo

public static final AttributeDefinition<String> PROXY_HOST = AttributeDefinition.builder(Attribute.EXTERNAL_HOST, null, String.class).immutable().build();
public static final AttributeDefinition<Integer> PROXY_PORT = AttributeDefinition.builder(Attribute.EXTERNAL_PORT, -1).immutable().build();
// The Hot Rod server has a different default
public static final AttributeDefinition<Integer> WORKER_THREADS = AttributeDefinition.builder("worker-threads", 160).immutable().build();

private final TopologyCacheConfiguration topologyCache;
private final EncryptionConfiguration encryption;

public static AttributeSet attributeDefinitionSet() {
return new AttributeSet(HotRodServerConfiguration.class, ProtocolServerConfiguration.attributeDefinitionSet(),
WORKER_THREADS, PROXY_HOST, PROXY_PORT);
PROXY_HOST, PROXY_PORT);
}

HotRodServerConfiguration(AttributeSet attributes,
Expand Down