ISPN-15494 Near cache with invalidation fails to start in Spring Boot #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
added
the
14.0.x
|
@karesti it seems OK. Some of the failures were handled in other PRs. |
|
Let me rebase it. |
Updated for the invalidated near cache instances. We check if the MANAGER marshaller is capable of handling the server type, and only then proceed with the usual flow. Either we register listener and set data format, or the inverse. If the marshaller is compatible with the server type, we exchange the type information when installing the listener. See, this might hide bugs that bite back during runtime! This might be found during runtime when executing some key based operation against the server. For internal caches, where the user won't interact directly through HR (resp), this is fine. We also have a warning in any case.
tristantarrant
force-pushed
the
ISPN-15494
branch
from
dfa172e
to
3f19d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-15494
Updated for the invalidated near cache instances. We check if the MANAGER marshaller handles the server type and only then proceed with the usual flow. Either we register the listener and set the data format or the inverse.
If the marshaller is compatible with the server type, we exchange the type information when installing the listener. See, this might hide bugs that bite back during runtime! During runtime, when executing some key-based operation against the server, an exception is thrown because it is not possible to convert between types, failing later instead of during start-up. We also log a warning message.
Note that it would be a similar behavior to before we added #11337.
Internal caches, where the user won't interact directly through HR (resp), should be fine.