ISPN-14645 Final string commands pending #11980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
force-pushed
the
pending-string-ops
branch
from
2c77909
to
6ef03aa
Compare
karesti
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14656
https://issues.redhat.com/browse/ISPN-14657
https://issues.redhat.com/browse/ISPN-14651
https://issues.redhat.com/browse/ISPN-14655
https://issues.redhat.com/browse/ISPN-14660
This should close https://issues.redhat.com/browse/ISPN-14645.
Also, the
SUBSTRis not covered in tests. Lettuce doesn't even have that command. Looking at the command documentation, they useGETRANGEinstead ofSUBSTRto show the examples.