Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.x] ISPN-15738 Avoid individual GET by Key in distributed query aggregation #12029

Merged
merged 2 commits into from Feb 22, 2024

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Feb 21, 2024

Use getAll to fetch multiple keys in a single RPC request. The batch is the same as the chunk-size for state transfer.

https://issues.redhat.com/browse/ISPN-15738

@pruivo pruivo added this to the 14.0.25.Final milestone Feb 21, 2024
@pruivo pruivo requested a review from fax4ever February 21, 2024 15:45
@pruivo pruivo changed the title ISPN-15738 Avoid individual GET by Key in distributed query aggregation [14.x] ISPN-15738 Avoid individual GET by Key in distributed query aggregation Feb 21, 2024
@pruivo pruivo force-pushed the t_query_iterator branch 3 times, most recently from e1e59d7 to c63bf2f Compare February 21, 2024 19:01
Use getAll to fetch multiple keys in a single RPC request.
The batch is the same as the chunk-size for state transfer.
In particular if the state transfer chunk size is larger and smaller than the max results
Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I added a test case as well.
+1 to merge it

@tristantarrant tristantarrant merged commit 392dfbe into infinispan:14.0.x Feb 22, 2024
3 of 5 checks passed
@pruivo pruivo deleted the t_query_iterator branch February 22, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants