ISPN-15738 Avoid individual GET by Key in distributed query aggregation #12030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fax4ever
reviewed
Feb 21, 2024
query/src/main/java/org/infinispan/query/clustered/DistributedIterator.java
Show resolved
Hide resolved
query/src/main/java/org/infinispan/query/clustered/DistributedIterator.java
Outdated
Show resolved
Hide resolved
Use getAll to fetch multiple keys in a single RPC request. The batch is the same as the chunk-size for state transfer.
pruivo
commented
Feb 21, 2024
query/src/main/java/org/infinispan/query/clustered/ClusteredQueryInvoker.java
Show resolved
Hide resolved
|
@fax4ever about the testing, just point me to the correct class and what kind of tests you have in mind. |
In particular if the state transfer chunk size is larger and smaller than the max results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use getAll to fetch multiple keys in a single RPC request. The batch is the same as the chunk-size for state transfer.
https://issues.redhat.com/browse/ISPN-15738