Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] ISPN-15860 Exception with async store when not segmented #12134

Closed
wants to merge 1 commit into from
Closed

[14.0] ISPN-15860 Exception with async store when not segmented #12134

wants to merge 1 commit into from

Conversation

wburns
Copy link
Member

@wburns wburns commented Mar 12, 2024

@github-actions github-actions bot added this to the 14.0.26.Final milestone Mar 12, 2024
@wburns wburns changed the title ISPN-15860 Exception with async store when not segmented [14.0] ISPN-15860 Exception with async store when not segmented Mar 12, 2024
@wburns
Copy link
Member Author

wburns commented Mar 13, 2024

Looks like some thread leaks, let me fix it up.

@wburns wburns force-pushed the ISPN-15860_async_store_non_segmented branch from 340a2b8 to 9c54ad3 Compare March 13, 2024 16:23
@wburns wburns force-pushed the ISPN-15860_async_store_non_segmented branch from 9c54ad3 to 9ba619c Compare March 13, 2024 16:24
@wburns
Copy link
Member Author

wburns commented Mar 13, 2024 •
edited

I have updated the DummyInMemoryStore to have a new configuration option asyncOperation which offloads the public store operations to the non blocking executor. This allows for the tests to more easily test bugs that may occur when a store operation is done asynchronously as in this case.

To reproduce the exception you can just change segmentToUse in AsyncNonBlockingStore to just return segment;

@wburns
Copy link
Member Author

wburns commented Mar 20, 2024

Closing in favor of #12140 backport

@wburns wburns closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0.28.Final
2 participants
@wburns @pruivo