ISPN-2167 Fixed issue where array offset and size were not used when cal... #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calling to ObjectStreamMarshaller.
|
Thanks Williams! Did you already sign our CLA? |
|
No I have not. Interestingly I didn't see notes on here https://docs.jboss.org/author/display/ISPN/Contributing+to+Infinispan to do so. Also when I google for infinispan CLA it does bring me to a jboss webpage but I am unable to do anything on the page :( |
|
@wburns Apologies for the lack of information in our site regarding the CLA. I've just added some info to https://docs.jboss.org/author/x/ZQFJ Our CLA site is https://cla.jboss.org/index.seam - is that the one you found? Basically, you have to log into your jboss.org account and sign one of the agreements (individual or company). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see from diff the code is passing in the original byte array instead of the copied version. Looking at the issue though there is really no need to copy the array when you could just pass it in with the offset and length as the commit has. This way is doesn't needlessly copy the data again.