ISPN-10957 Support index/query by key for remote queries #12281
Conversation
fax4ever
force-pushed
the
fix-toConvertedEntityJavaClass
branch
2 times, most recently
from
0735701
to
22b8154
Compare
fax4ever
changed the title
object-filter/src/main/java/org/infinispan/objectfilter/impl/syntax/IndexedFieldProvider.java
Show resolved
Hide resolved
fax4ever
force-pushed
the
fix-toConvertedEntityJavaClass
branch
from
3679ec5
to
86eaed5
Compare
|
Thank you @tristantarrant for the review. I added this commit to make the no index field provider caches as static instance again: 86eaed5. |
|
@fax4ever please also include documentation about this feature |
I tried to write it |
| = Queries by keys | ||
|
|
||
| If a key of a cache entry has an indexed type, it is possible to index the key fields as well the the value fields, | ||
| so that also the formers could be used in the `Ickle` queries. |
There was a problem hiding this comment.
Former cannot be pluralized. Reword as:
Use indexed types as keys to query caches by key using Ickle.
|
|
||
| [NOTE] | ||
| ==== | ||
| This feature is at the moment available only with indexed remote queries. |
There was a problem hiding this comment.
This feature is currently only available with indexed remote queries.
|
|
||
| If the value already has a property named `key`, the definition of the key entity could create a naming conflict | ||
| with the properties. | ||
| For this reason but also in general, |
There was a problem hiding this comment.
Remove this part of the sentence and start it with "It is possible..."
fax4ever
force-pushed
the
fix-toConvertedEntityJavaClass
branch
from
e9dbc9d
to
2c39f50
Compare
|
Thanks @tristantarrant. I applied the changes to the doc. |
I think we need one for each generic type, since we cannot make static a generic instance.
fax4ever
force-pushed
the
fix-toConvertedEntityJavaClass
branch
from
2c39f50
to
33ba85a
Compare
https://issues.redhat.com/browse/ISPN-10957