Rolling upgrade support #1340
Closed
Rolling upgrade support #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Looking into this |
| val combinedKeyset = new java.util.HashSet[ByteArrayKey]() | ||
|
|
||
| for (future <- new IteratorWrapper(keysets.iterator())) { | ||
| combinedKeyset addAll future.get() |
There was a problem hiding this comment.
Maybe remove KNOWN_KEY from the set ?
…d cluster to a new one
…a well-known key, via JMX
|
Fixed. Nothing to do with a missing file, just that I renamed MigrationManager to RollingUpgradeManager and my IDE's refactoring tools conveniently ignored Scala source files. :) Fixed, rebased, etc., and all good to go. |
|
Pulling |
|
Pulled. We need some tests now :) |
| } | ||
|
|
||
| class IteratorWrapper[A](iter:java.util.Iterator[A]) { | ||
| // TODO: should probably be in some generic scala helper module to allow scala-style iteration over java collections |
There was a problem hiding this comment.
No need for this. That's what scala.collection.JavaConversions is there for (used throughout the code base).
|
This really shouldn't have been pulled without proper tests :( |
| @ManagedOperation(description = "Dumps the global known keyset to a well-known key for retrieval by the upgrade process") | ||
| @Operation(displayName = "Dumps the global known keyset to a well-known key for retrieval by the upgrade process") | ||
| public void recordKnownGlobalKeyset() { | ||
| for (Migrator m: migrators.values()) m.recordKnownGlobalKeyset(); |
There was a problem hiding this comment.
Should we throw an exception if no migrators are found ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a basic version of the plan outlined in https://community.jboss.org/wiki/RollingUpgradesInInfinispan under section 1: Rolling upgrades for remote clients using Hot Rod
RollingUpgradeSynchronizercould be better: controlled via JMX and not just the command line. And in the case of command-line, should ship with a set of scripts. But this can be integrated for now, and the additional pieces added in a separate commit.HotRodMigratorcan be abstracted into a generic class and reused for other migrators, for in-VM, memcached and REST, but this can be refactored when implementing phase 2 and 3 of the design.Relevant JIRAs can be found on https://community.jboss.org/wiki/RollingUpgradesInInfinispan, as well as https://issues.jboss.org/browse/ISPN-2345 and https://issues.jboss.org/browse/ISPN-2346