Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-2503 Re-enable FD_SOCK in the test suite #1673

Closed
wants to merge 1 commit into from

Conversation

danberindei
Copy link
Member

https://issues.jboss.org/browse/ISPN-2503

Please cherry-pick on 5.2.x as well.

Fixes the core test suite hanging on Sanne's machine.

It does create 2 extra threads per cache manager (1 pinger + 1 acceptor), but none of them will actually do any work.

@ghost ghost assigned Sanne Feb 21, 2013
@mmarkus
Copy link
Contributor

mmarkus commented Feb 21, 2013

assigned to @Sanne to check for the failure.

@Sanne
Copy link
Member

Sanne commented Feb 21, 2013

need access to home workstation.. postponed to the weekend would be fine?

@danberindei
Copy link
Member Author

You're the only one seeing the failure for now, so whenever you have the
time to do it is fine :)

On Thu, Feb 21, 2013 at 3:28 PM, Sanne Grinovero
notifications@github.comwrote:

need access to home workstation.. postponed to the weekend would be fine?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1673#issuecomment-13894446.

@Sanne
Copy link
Member

Sanne commented Feb 26, 2013

@danberindei I still have lots of problems, it's hard to say if this improved any.
But it still looks like a good idea, should we merge anyway?

@anistor
Copy link
Member

anistor commented Feb 26, 2013

@Sanne I've merged this a few mins ago. For me it solved a randomly hanging CacheClusterJoinTest.

@anistor
Copy link
Member

anistor commented Feb 26, 2013

Integrated in both master and 5.2.x. Thanks!

@anistor anistor closed this Feb 26, 2013
@danberindei
Copy link
Member Author

@Sanne Do you mean your test suite is still hanging? Please post a thread dump if that's the case.

@Sanne
Copy link
Member

Sanne commented Feb 26, 2013

@anistor ok cool.

@danberindei I'll send you an email. thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants