ISPN-2281 Initial Embedded and Hot Rod compatibility #1790
Conversation
|
Just added a commit to add a putIfAbsent call with Metadata so that Memcached tests pass. It all looks good now testing wise. |
|
|
||
| // AdvancedCache<K, V> withMetadata(Metadata metadata); | ||
|
|
||
| V put(K key, V value, Metadata metadata); |
|
@maniksurtani Added javadoc |
|
@tristantarrant Removed commented code and updated XSD |
|
Looks good to me. |
|
Removed public from metadata interface. I'm also checking the testsuite failures now... |
|
Don't merge this guys, the failing tests are showing some logic is missing to deal with the fact that CHMv8 can be serialized. I'm checking to see what the implications are on Equivalence interface. |
|
Guys, the testsuite stuff has been fixed. I don't think the remaining failures are related to the commits. |
|
Oh, one sec, the xsite failures are new... and are not run by default when running core/... so they might be related... i'll investigate... |
|
Oh, one sec, seems like some of these xsite and tree failures are already in master, see http://54.235.219.66/viewLog.html?buildId=906&buildTypeId=bt9 vs http://54.235.219.66/viewLog.html?buildId=925&tab=buildResultsDiv&buildTypeId=bt2 Nothing to be fixed then at least as far as this pull req is concerned. |
* Added revision numbers for each class so that they can be compared with the CVS repository and see if any update happened since last time they were updated.
* Comparing function classes for key/values can now be defined via XML or programmatic configurations. * If any Comparing functions given, either ComparingCHMv8 or BoundedCHM taking Comparing function(s) are used.
* Added EquivalentHashSet and EquivalentHashMap collections to support byte[] key types in invocation contexts. * Refactored ConcurrentMapFactory to a CollectionFactory that can create not only concurrent maps, but maps and sets, based on equivalence configuration.
* AdvancedCache adds a couple of new methods that take metadata as parameter. This can be used by users to provide version, and also for server implementations to add their own metadata (i.e. REST servers and MIME data). * The implementation of these methods is temporary and is bound to change in order to feed the metadata object all the way to the cache entry. * There's an initial stab at the compatibility testing with initial focus on Embedded and Hot Rod server. Tests here are not yet working.
|
Rebased. |
| import java.io.Serializable; | ||
|
|
||
| /** | ||
| * An interface that allows custom implementations for objects are comparable |
There was a problem hiding this comment.
...for objects that are comparable...
| import static org.testng.AssertJUnit.*; | ||
|
|
||
| /** | ||
| * // TODO: Document this |
* Remove CHMv8 and leave only the equivalent version * Add putIfAbsent with Metadata so that Memcached tests pass * Add javadocs for Metadata related additions * Update configuration XSD and remove commented code * Make Equivalence extend Serializable and fix tests * Remove commented code sections * Add missing javadocs
|
Updated the last commit based on comments. This should be ready now. |
|
@galderz I'll leave the JIRA opened as there are still some things to do. |
It contains:
Please note that some Memcached tests are failing because I don't yet have a putIfAbsent method that takes a metadata object. I'll get that sorted tomorrow morning and add a commit to fix it.
In the mean time, please review this so that it can get into the next alpha :)