Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-3170 create a Metadata store #1952

Closed
wants to merge 1 commit into from

Conversation

mmarkus
Copy link
Contributor

@mmarkus mmarkus commented Jul 5, 2013

@galderz
Copy link
Member

galderz commented Jul 5, 2013

@mmarkus Why is this needed exactly? The design document doesn't explain it either.

Also, what does this mean for other inner metadata usages, such as the Hot Rod view information?

I'm also slightly worried about the naming here. We're using Metadata class for user provided meta data. We should maybe try to distinguish a bit between both? Easier to do it in the inner classes than in the user-facing ones.

@mmarkus
Copy link
Contributor Author

mmarkus commented Jul 5, 2013

@galderz I've updated the JIRA with some context.

Also, what does this mean for other inner metadata usages, such as the Hot Rod view information?

I think the hotrod topology cache can be dropped and put the topology information in this cache.

I'm also slightly worried about the naming here. We're using Metadata class for user provided meta data. We should maybe try to distinguish a bit between both? Easier to do it in the inner classes than in the user-facing ones.

The name of the component (package + class) is "ClusterRegistry" - precisely in order to avoid confusion with the o.i.metadata

* @since 6.0
*/
@ThreadSafe
public class ClusterRegistryImpl implements ClusterRegistry {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generics defined in the interface but not used in the implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@galderz
Copy link
Member

galderz commented Jul 9, 2013

I'm done with my comments, thanks @mmarkus :)

@mmarkus
Copy link
Contributor Author

mmarkus commented Jul 9, 2013

@galderz all comments answered ;)

@galderz galderz closed this Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants