ISPN-3175 Upgrade the java hotrod client to support remote querying #2022
Conversation
| import org.infinispan.client.hotrod.impl.query.RemoteQueryFactory; | ||
| import org.infinispan.query.dsl.QueryFactory; | ||
|
|
||
| //todo isn't it better to expose this directly on RemoteCache? |
There was a problem hiding this comment.
Hmmmm, I guess we need to map to what happens with embedded Cache + embedded Query, right?
There was a problem hiding this comment.
yes, ideally remote and embedded APIs should be identical, with the exception here were the class comes from another package.
|
Good stuff @anistor :), ping the dev list (better actually) if you wanna talk about how to enhance interoperability/compatibility mode to better accommodate your type converter requirements for remote query... |
|
@galderz I've updated the PR but not all the items are solved yet. |
|
@anistor Ok, put an update when the other items have been resolved and the PR is updated. |
|
@anistor All items resolved now? |
|
Nope, but getting closer. Will update again this evening. |
|
@galderz I've updated it now and I'm satisfied with the results (even though there still are loads of TODOs). I would suggest integrating as is so we can have this in the next alpha/beta release. There is one remaining item, the RemoteValueWrapperInterceptor might not be the ideal solution for what I'm trying to achieve. I will ask the devlist today and depending on the opinions we collect we might change this after the release. Thanks! |
…figuration of the HotRod client
…ss so it can be used by remote-query module
* Add remote-query module and QueryFacade implementation * Remove the checked exception declared by QueryFacade.query method * KeyTransformationHandler should provide default support for byte[]
Jira: https://issues.jboss.org/browse/ISPN-3175
Please integrate in master.