ISPN-3487 Missing protobuf fields sould be indexed with their declared d... #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d default value (if any) instead of being indexed as null * Refactor MessageContext to reuse the similar class already present in protostream lib * Upgrade to a newer protostream that has less unwanted dependecies * Also make remote-query related dependecies optional in HotRod client
| @@ -54,7 +54,7 @@ | |||
|
|
|||
| <properties> | |||
| <!-- Versions for dependencies --> | |||
| <version.protostream>1.0.0.Alpha4</version.protostream> | |||
| <version.protostream>1.0.0-SNAPSHOT</version.protostream> | |||
There was a problem hiding this comment.
Hmmmm, we try to avoid SNAPSHOT dependencies as much as we can... resolve this into a fixed release ASAP, preferably before next release, to avoid releasing software with moving parts.
There was a problem hiding this comment.
I know but I'm planning to make so more changes to protostream and release 1.0.0.Alpha5 only right before the infinispan release. This would avoid polluting the repo with useless intermediate releases. That's what snapshots are for.
|
Looks good otherwise. Release an alpha5 or beta of protostream, change the version in the pom, and we can integrate it. |
…span Lucene Directory provider
|
I've updated the PR and released protostream 1.0.0.Alpha5. |
|
Thanks @anistor!!! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...efault value (if any) instead of being indexed as null
Also fixes ISPN-3488
Jira: https://issues.jboss.org/browse/ISPN-3487 ,
https://issues.jboss.org/browse/ISPN-3488
Please integrate in master.