ISPN-3316 Avoid use of @Alternative for Infinispan components #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
galderz
commented
Nov 20, 2013
galderz
commented
- In CDI 1.0, alternative components cannot be injected in libraries used by deployments. In other words, only components used by the app directly can be switched with alternative.
- An alternative set of Cache*Interceptor classes have been developed for use in managed environments, which indirectly use the InjectedCacheResolver.
- Indirectly solved an issue where cache managers where being left open in CDI/JCache integration tests. This was the result of JCacheManager trying to stop cache managers for which it didn't control lifecycle.
| @@ -0,0 +1,90 @@ | |||
| /* | |||
There was a problem hiding this comment.
the license header was removed from the class. I think the same applied in this case right? If yes, don't forget to remove also in the other new classes
* In CDI 1.0, alternative components cannot be injected in libraries used by deployments. In other words, only components used by the app directly can be switched with alternative. * An alternative set of Cache*Interceptor classes have been developed for use in managed environments, which indirectly use the InjectedCacheResolver. * Indirectly solved an issue where cache managers where being left open in CDI/JCache integration tests. This was the result of JCacheManager trying to stop cache managers for which it didn't control lifecycle. * Remove license headers from all source files that had them.
|
Pull request updated |
|
pulling |
|
integrated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.