ISPN-3829 Null value read with RR can be replaced by cache loader value #2295
Conversation
| * get only if the value is null (Repeatable Read) | ||
| */ | ||
| protected boolean shouldAttemptLookup(CacheEntry e) { | ||
| return e == null || (e.isNull() || e.getValue() == null) && !e.skipRemoteGet(); |
There was a problem hiding this comment.
I would suggest to change the name of skipRemoteGet() to something like skipFetch(). Also, change the name of the internal flag and the setter :)
* Fixed issue where RR if found null woud still query cache loader
|
Changed and refactored all the references. I was hesitant since it is on an interface, but this is 7.0 so I would think it is okay. Let me know! |
|
Actually this issue is a candidate to put into 6.0.2, is the change of the interface in that case okay? @mmarkus ? |
|
Sounds good, I just wanted to confirm. I am so used to previous work that basically anyone may have extended our interfaces even internal ones, so I was always overly cautious. |
|
@wburns would make sense to have an annotation stating that something is public API or not, would be easier for the clients and us to handle things that way. @tristantarrant wdyt? |
|
pulling... |
|
@wburns thank you! |
https://issues.jboss.org/browse/ISPN-3829