ISPN-3910 HotRod authentication #2532
Conversation
tristantarrant
changed the title
|
Remove the integration code from this PR (ISPN-3911). It will be readded when we rebase our server code to WildFly. |
| @@ -43,18 +45,29 @@ abstract class AbstractProtocolDecoder[K, V](transport: NettyTransport) | |||
| protected var cache: AdvancedCache[K, V] = null | |||
| protected var defaultLifespanTime: Long = _ | |||
| protected var defaultMaxIdleTime: Long = _ | |||
|
|
|||
| var subject: Subject = null | |||
There was a problem hiding this comment.
Does this need to go here? This class is designed to contain stuff used for both memcached and Hot Rod. Since we're only adding Hot Rod stuff here, wouldn't it make more sense to add it to HotRodDecoder?
There was a problem hiding this comment.
In future, when we move to a ProtocolServer for REST (using the Netty <> Resteasy bridge) I want to handle security in only one way
|
@tristantarrant Needs rebasing as indicated on IRC. Other than that it looks good :) |
|
Oh, the |
|
Yeah, I saw that, let me check my tests if they cleanup correctly |
|
@galderz Rebased and fixed the failing test by using UniquePort :) |
|
Two minor updates: I had forgotten a configuration item for the client (serverName) and I've implemented a method for searching and caching all available SASL mechs |
|
Integrated, thanks @tristantarrant :) |
https://issues.jboss.org/browse/ISPN-3910 HotRod Authentication
https://issues.jboss.org/browse/ISPN-4174 Audit Logging