ISPN-4295 Include Lucene Directory in the released WildFly modules #2582
Conversation
| @@ -3,9 +3,10 @@ | |||
| <property name="output.dir" value="${project.build.directory}/infinispan-as-modules" /> | |||
|
|
|||
| <import file="lib.xml" /> | |||
|
|
|||
There was a problem hiding this comment.
you should try avoid any change which is not directly related with the fix;
I am trying to not be too annoying about this usually, but you should try at least as we have various good reasons:
- avoids unnecessary conflicts, especially if stuff gets backported after long time
- makes reviewers life easier to focus on the stuff that matters
Commits which do cleanup formatting are ok - and sometimes necessary - we just try to keep them in independent commits and warn the reviewer with some notice like "formatting only", "converting tabs to spaces" ..
There was a problem hiding this comment.
Sorry, my IntelliJ "Strip trailling spaces on save" setting was on, and I've forgot to double check the diff
There was a problem hiding this comment.
Ok. I like files without trailing spaces better too (especially on new source) but generally speaking it's better to disable such automation.
|
This can't really be pulled before #2558 |
|
@tristantarrant ok :-/ I don't think #2583 should affect this, a test run after rebase should suffice. |
|
PR Updated. Now releasing:
|
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <property name="output.dir" value="${project.build.directory}/infinispan-as-modules" /> | |||
|
|
|||
| <import file="lib.xml" /> | |||
| <import file="../lib.xml" /> | |||
There was a problem hiding this comment.
Are you sure of this change? I wasn't expecting you to need to change other aspects of the build
|
merged |
No description provided.