ISPN-4056 Enable caching of permission masks to cluster registry #2618
Conversation
| @@ -219,7 +219,7 @@ TransportConfigurationBuilder read(TransportConfiguration template) { | |||
| this.properties = template.properties(); | |||
| this.rackId = template.rackId(); | |||
| this.siteId = template.siteId(); | |||
| this.transport = template.transport(); | |||
| this.transport = Util.getInstance(template.transport().getClass().getName(), template.transport().getClass().getClassLoader()); | |||
There was a problem hiding this comment.
@tristantarrant doesn't WildFly rely on injecting an actual Transport instance with a JChannel set? If not, I would propose going further, and removing the Transport (and any other objects that cannot be safely reused between caches/managers) from the configuration.
There was a problem hiding this comment.
The server uses the default tranport but sets a number of additional properties to configure the channel lookup.
There was a problem hiding this comment.
So how do you feel about removing the Transport from the configuration altogether?
There was a problem hiding this comment.
Hm I was mistaken, our "Infinispan Server" code still uses that method, but the new WildFly code uses a custom transport which extends JGroupsTransport and is constructed specifically.
|
Closing for now, will come back with more stuff |
|
Ah, I was hoping it's closed because someone integrated it already :) |
https://issues.jboss.org/browse/ISPN-4056
also fixes a couple of bugs that were affecting the test.