ISPN-4400 Takes a long time to start up all clusters which has a lot of ... #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return segments; | ||
| synchronized (segments) { | ||
| Set<Integer> segmentsCopy = new HashSet<Integer>(segments); | ||
| segmentsCopy.addAll(segments); |
|
synchronization is missing in |
| @@ -33,9 +32,15 @@ | |||
| private static final Log log = LogFactory.getLog(InboundTransferTask.class); | |||
| private static final boolean trace = log.isTraceEnabled(); | |||
|
|
|||
| private final Set<Integer> segments = new CopyOnWriteArraySet<Integer>(); | |||
| /** | |||
| * All access to fields {@code segments} and {@code finishedSegments} must bead done while synchronizing on {@code segments}. | |||
There was a problem hiding this comment.
I would prefer to see a new Object to synchronize, but I can live with it...
|
the rest looks good :) |
|
InboundTransferTask.toString() is only used during debugging and the lack of syncronization does not induce any state corruption, it may however be a nuisance to the caller. I've added syncronization. |
…of segments This is mainly caused by the myriad of internal copies performed by the CopyOnWriteArraySet used in InboundTransferTask for tracking the segments being requested during ST. This collection is updated way too frequently if we have a large number of segments. It seems that using a simple HashMap and doing external synchronization works better both in terms of time and memory.
|
I just say that because it can throw |
|
looks good, testing and pulling... |
|
integrated! thanks @anistor ! |
|
Thanks @pruivo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...segments
This is mainly caused by the myriad of internal copies performed by the CopyOnWriteArraySet used in InboundTransferTask for tracking the segments being requested during ST. This collection is updated way too frequently if we have a large number of segments. It seems that using a simple HashMap and doing external synchronization works better both in terms of time and memory.
Jira: https://issues.jboss.org/browse/ISPN-4400