ISPN-4478 ServerFailureRetrySingleOwnerTest should remove listener #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
galderz
commented
Jul 3, 2014
galderz
commented
- Before, the error inducing listener was not being removed, and that was not appearing as a result that each test was creating a new bunch of cache managers. Now, clean up is done after the test class has finished and the listeners are correctly removed.
| public class ServerFailureRetrySingleOwnerTest extends AbstractRetryTest { | ||
|
|
||
| public ServerFailureRetrySingleOwnerTest() { |
There was a problem hiding this comment.
Is the cleanup required after test still? I would think if we are properly removing the listener we should okay or is it that data is an issue as well?
There was a problem hiding this comment.
It speeds the test hugely by not starting/stopping a cache manager for each test. This is independent of the actual fix.
There was a problem hiding this comment.
Sorry I for some reason got AFTER_TEST and AFTER_METHOD mixed up :) We are on the same page :)
* Before, the error inducing listener was not being removed, and that was not appearing as a result that each test was creating a new bunch of cache managers. Now, clean up is done after the test class has finished and the listeners are correctly removed.
|
Pulling... |
|
Integrated into master, thanks @galderz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.