ISPN-4505 Lucene Directory polishing #2706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -269,7 +255,7 @@ private Boolean containsKeyIntern(final ChunkCacheKey chunkCacheKey) throws IOEx | |||
| final long length = directory.fileLength(chunkCacheKey.getFileName()); | |||
| final int bufferSize = chunkCacheKey.getBufferSize(); | |||
| final int chunkId = chunkCacheKey.getChunkId(); | |||
| return Boolean.valueOf((chunkId * bufferSize) < (length + bufferSize)); | |||
There was a problem hiding this comment.
Since auto-boxing can be a performance pain when it happens unintentionally, we made the choice to set IDEs to flag these as a warning, hence it's preferrable to keep it as an explicit operation when we need to use the "uppercase versions" of primitives.
|
Thanks Gustavo! I reverted the couple of auto-boxing changes - especially as they didn't seem related with the overall issue at hand - and then applied it. I'd normally should have waited but there where lots of nice improvements at risk of conflicts, so I went ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.