New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-1951 Use MERGE3 in the default UDP configuration #2744
Conversation
Updated to remove UFC from the TCP configs as well: |
@@ -284,7 +284,7 @@ public String toString() { | |||
enum ProtocolType { | |||
TCP, UDP, | |||
MPING, PING, TCPPING, TEST_PING, | |||
MERGE2, | |||
MERGE2, MERGE3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MERGE2
can be removed? or is it needed somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have UNICAST and UNICAST2 in the list, I figured it's to allow us to test with another protocol when we suspect one is giving us problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that is a good reason :)
|
|
Both updated |
testing and pushing... |
integrated! thanks @danberindei ! |
https://issues.jboss.org/browse/ISPN-1951