Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-4644 ISPN-4258 ISPN-4012 MassIndexer performance enhancements #2813

Closed
wants to merge 5 commits into from

Conversation

gustavocoding
Copy link

https://issues.jboss.org/browse/ISPN-4644
https://issues.jboss.org/browse/ISPN-4258
https://issues.jboss.org/browse/ISPN-4012

Instead of committing on each individual document plus on each map execution, it will commit only once per MassIndexer execution.
Also avoid using the SharedWorkspace setting on all MassIndexer tests, since it does heavy synchronization assuming the index is shared (which is not)

@anistor
Copy link
Member

anistor commented Aug 22, 2014

Looking..

@gustavocoding gustavocoding changed the title ISPN-4644 & ISPN-4258 MassIndexer performance enhancements ISPN-4644 ISPN-4258 ISPN-4012 MassIndexer performance enhancements Aug 25, 2014
@gustavocoding
Copy link
Author

Rebased and enabled 3 other releated tests

@@ -64,7 +64,6 @@ protected void rebuildIndexes() throws Exception {
"start", new Object[]{}, new String[]{});
}

@Test(groups ="unstable")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method should be removed entirely.

@anistor
Copy link
Member

anistor commented Sep 1, 2014

@gustavonalle Looks good. I can fix those comments myself and integrate. Or would you like @Sanne to have a look at it too?

@anistor
Copy link
Member

anistor commented Sep 1, 2014

Integrated. Thanks!

@anistor anistor closed this Sep 1, 2014
@gustavocoding gustavocoding deleted the massindexer branch November 27, 2014 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants