ISPN-1261 Implemented missing CDI events

[slaskawi]

Hi!

Please take a look at the implementation of missing events: https://issues.jboss.org/browse/ISPN-1261.

It turned out, that there was a problem with Weld implementation and generic type of the events (EventImpl<K,V>). IMO Weld implements CDI spec correctly here (CDI spec 10.3), so I introduced a small wrapper around Events and, to make it type safe - it's an inner class of adapters.

I'm not sure if we should supporting deprecated CacheEntriesEvictedAdapter. I removed it, but perhaps we should leave it?

Best regards
Sebastian

[galderz]

Not sure I understand why this class cannot be an inner static class, it doesn't seem to use any externally defined instances. It simply takes a decoratedEvent and delegate to it. Also, I don't see any references to CDICacheEntriesEvictedEvent anywhere else, so maybe it could be even be private?

[slaskawi]

Here is a very good explanation why we can't make it static: http://stackoverflow.com/questions/12334159/jls7-generic-inner-class-documentation-error/12334315#12334315

Actually we need K and V in here CacheEntriesEvictedEvent<K, V>. These generic type information must be passed here from enclosing class. Another solution would be simply to discard all generics in this inner class and then we might have made it static.

And for making it private: +1 :)

[galderz]

Good point, that's Ok then.

[galderz]

Excellent work @slaskawi :), just some small comments on the code. As long as CacheEntryEvicted is present in core/ module and since CacheEntryEvictedAdapter was already present in the CDI module, we need to continue supporting it. Once CacheEntryEvicted is removed from core, we can remove related work in CDI.

[slaskawi]

Ok now it's clear - CacheEntryEvicted needs to be preserved.... at least for now...

[galderz]

Integrated, thanks @slaskawi :)