ISPN-4575 Map/Reduce incorrect results with a non-shared non-tx intermed... #2853
Conversation
| int expectedSize = cacheManager.getTransport().getMembers().size(); | ||
| while (stm.getCacheTopology().getMembers().size() != expectedSize && stm.getCacheTopology().getPendingCH() != null) { | ||
| Thread.sleep(50); | ||
| if (System.nanoTime() > giveup) { |
There was a problem hiding this comment.
This should do subtraction then compare to 0 as defined in System.nanoTime javadoc
There was a problem hiding this comment.
Thanks @wburns Have a look now please!
| String message = String.format( | ||
| "Creating tmp cache %s timed out waiting for rebalancing to complete on node %s ", cacheNameToCreate, | ||
| cacheManager.getAddress()); | ||
| log.error(message); |
There was a problem hiding this comment.
seems we should have this as a Log method?
There was a problem hiding this comment.
@vblagoje You missed this comment
There was a problem hiding this comment.
Yep, on it. Thanks @danberindei
|
It seems okay to me, but @danberindei is the ST guy to know for sure. |
|
Okay, thanks @wburns . What do you think @danberindei ? |
|
Compilation error in CI: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project infinispan-cli-server: Compilation failure |
|
Thanks @danberindei , will correct it. |
|
@danberindei updated and rebased |
danberindei
force-pushed
the
master
branch
3 times, most recently
from
8465ee1
to
8c3c08c
Compare
danberindei
added
Ready for Review
and removed
Suggestions please?
Changes Required
labels
|
I think it needs a rebase: [org.infinispan:infinispan-core] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project infinispan-core: Compilation failure |
| @@ -105,10 +106,10 @@ public void createCache(String cacheName, String baseCacheName) { | |||
| CommandsFactory factory = clusteredCache.getComponentRegistry().getComponent(CommandsFactory.class); | |||
|
|
|||
| CreateCacheCommand ccc = factory.buildCreateCacheCommand(cacheName, baseCacheName); | |||
|
|
|||
| StateTransferManager transferManager = clusteredCache.getComponentRegistry().getComponent(StateTransferManager.class); | |||
There was a problem hiding this comment.
ComponentRegistry has special methods to look up both the StateTransferManager and the CommandsFactory.
|
Integrated, thanks Vladimir! |
Master only. Dan should review. For more details see https://issues.jboss.org/browse/ISPN-4575