ISPN-4884 Deployment scanner is neeeded to deploy filter/converters... #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
galderz
commented
Oct 27, 2014
galderz
commented
- Without the deployment scanner, is not possible to deploy filter, converter and marshaller instances for enhanced Hot Rod remote events.
|
Looking |
| @@ -0,0 +1,47 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
We don't need this since we layer on top of an unpacked wildfly which already includes it.
|
Just one micro change, and it's ready. |
* Without the deployment scanner, is not possible to deploy filter, converter and marshaller instances for enhanced Hot Rod remote events.
|
Fixed and updated PR |
|
Looking good, pulling |
|
Done, thanks @galderz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.