Ispn 4951 Entry Retriever iterator should rethrow caused exception #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import static org.testng.AssertJUnit.*; | ||
|
|
||
| /** | ||
| * @author Mircea Markus |
There was a problem hiding this comment.
Author and since tags outdated?
There was a problem hiding this comment.
Yeah I copied this from somewhere as is. To be honest this shouldn't be in here, it must have snuck in. I will just remove it, Thanks.
|
Looks good, some minor things. It also needs rebasing. |
* Pass along any local throwable to iterator * If remote node receives throwable propagate that as a response
|
Rebased and removed erroneously added class. |
danberindei
added
Changes Suggested
Ready for Review
and removed
Ready for Review
labels
|
@danberindei I created https://issues.jboss.org/browse/ISPN-4982 to take care of the issue with activations. I don't want to muddy up this JIRA with it. |
|
Ok, integrating... |
|
Btw, #3077 has the fixes for it. |
|
Done, thanks Will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-4951