ISPN-5180 Try standard serialization if unmarshalled entry still byte[] #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // to make the client behave in compatibility mode, and hence only | ||
| // try using standard serialization if compatibility is enabledd. | ||
| if (ret instanceof byte[]) { | ||
| try (ObjectInputStream ois = new ObjectInputStream(new ByteArrayInputStream((byte[]) ret))) { |
There was a problem hiding this comment.
Maybe a quick check for the "magic" value at the beginning before attempting to read it via OIS ?
There was a problem hiding this comment.
Good idea :) I'll resubmit
|
@tristantarrant Updated |
|
Pushed, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might not the ideal solution, but one that requires least amount of change.
Another alternative solutions might require HotRodTypeConverter to send back byte[] instances as-is, rather than trying to marshall them again (which is why you can still have a standard serialized object marshalled again with the marshaller).
Yet another alternative is to add a configuration flag in RemoteCacheManager to enable compatibility so that it works optimally when compatibility is enabled.
Yet, yet, another alternative is to have enforce that such use case requires a custom marshaller to be installed, but this shouldn't be required IMO to deal with Java standard serialization.