ISPN-5152 Custom interceptor with Position.OTHER_THAN_FIRST_OR_LAST caus... #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,17 +229,12 @@ public boolean addInterceptorAfter(CommandInterceptor toAdd, Class<? extends Com | |||
| } | |||
| } | |||
|
|
|||
| public boolean addInterceptorBefore(CommandInterceptor toAdd, Class<? extends CommandInterceptor> beforeInterceptor, boolean isCustom) { | |||
There was a problem hiding this comment.
This is public API, so we should just deprecate it now.
There was a problem hiding this comment.
I think it is internal. we have a AdvanceCache.addInterceptorBefore/After() method.
There was a problem hiding this comment.
It's in a public package, so I'm assuming there is a way for the user to get a hold of an InterceptorChain instance... if not, it would be nice to move it to the impl package.
…auses CacheManager start to fail
pruivo
force-pushed
the
ISPN-5152/custom_interceptor
branch
from
8c70d7c
to
0551052
Compare
|
@danberindei updated (added |
|
Integrated, thanks Pedro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...es CacheManager start to fail
https://issues.jboss.org/browse/ISPN-5152