Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-5254 Server not always stopped properly with the IBM JDK #3281

Closed
wants to merge 2 commits into from
Closed

ISPN-5254 Server not always stopped properly with the IBM JDK #3281

wants to merge 2 commits into from

Conversation

vchepeli
Copy link
Contributor

@vchepeli vchepeli commented Mar 4, 2015

No description provided.

@vchepeli
Copy link
Contributor Author

vchepeli commented Mar 4, 2015

Hey @danberindei! Can you please review it?

<target name="-do.kinit" depends="-check.skipped" unless="tests.skipped">
<exec executable="bash" output="ps.pid" resultproperty="ps.result" failifexecutionfails="false" failonerror="false" osfamily="unix">
<arg value="-c"/>
<arg value="ps -eaf --columns 20000 | grep jboss-modules.jar | grep -v -w grep | awk '{print $$2;}'"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps -fCjava should filter by command name and avoid the need for grep -v -w grep - unless -C is not supported on one of the OSes we test on.

@danberindei
Copy link
Member

We also have a kill-jbossas.xml build script in server/integration/testsuite that does exactly the same thing. Ideally we should have only one, but otherwise we need to replicate the changes there as well.

@vchepeli
Copy link
Contributor Author

Hey @danberindei ! Added new changes. I cant use ps -Cf because Solaris does not have such option

@danberindei
Copy link
Member

@chepa653 oh well, I guess we'll have to keep it like that then.

@galderz
Copy link
Member

galderz commented Mar 12, 2015

@chepa653 What's up with the duplication highlighted by @danberindei? Is that correct? Can we sort it out?

@danberindei
Copy link
Member

Integrated, thanks Vitalii!

@galderz yeah, it would be nice to unify the Ant build scripts, but I found a couple more IBM java processes lying around on the build agent machine this morning, so I'm integrating this PR as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants