ISPN-5271 Usage of filter composition in DistributedEntryRetriever.sendRequest prevents dependency injection to filter and converter #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this was related to the old usage of the KeyFilter interface with loaders, now it should have a genereci name * old field aliased for backward compat
…one step * perform the instanceof KeyValueFilterConverter check once and remember the result for efficiency * move all calls to LocalEntryRetriever.wireFilterAndConverterDependencies(..) inside DistributedEntryRetriever.startRetrievingValues(UUID identifier, Set<Integer> segments, ...) * avoid possible NPE in DistributedEntryRetriever.updatedLocalAndRun( )
…ndRequest prevents dependency injection to filter and converter
…otobuf marshalling
…nalizer and are also Serializable
|
Integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for 7.1.x !
Jira: https://issues.jboss.org/browse/ISPN-5271
https://issues.jboss.org/browse/ISPN-5277
https://issues.jboss.org/browse/ISPN-5279