ISPN-5338 Extend JSR-107 tests #3436
Conversation
mcimbora
force-pushed
the
t_ISPN-5338
branch
2 times, most recently
from
64e6ce9
to
fecf0cf
Compare
|
Rebased. Looks like JCacheTwoCachesExpirationTest.testExpiration is still not passing. |
|
It always passes for me, what errors are you getting? |
|
It's passing as it's overriden in child class (see remote module, JCacheTwoCachesExpirationTest:35). As for the outcome of the test, I'm getting the following failure: JCacheTwoCachesExpirationTest>AbstractTwoCachesExpirationTest.testExpiration:37 expected [0] but found [1] Looks like expired listener is not notified after an entry has expired. It's test with 2 clustered caches. |
|
I'll have to flip expected/actual values. |
|
@mcimbora fair enough, I actually did not look at the code 😄 |
|
@galderz can confirm, but I don't think expiration notification was ever supported in JCache. Even for the embedded test, removing |
|
Indeed @gustavonalle is right, expiration events are not currently supported. This was an oversight, probably due to the fact that the TCK does not test those. @mcimbora Can you create a JIRA for this? Feel free to have a go as well if you fancy :) |
|
@galderz @gustavonalle Thanks for feedback. I created JIRA for this (ISPN-5482). Indeed, I was looking at some ways how to contribute and JCache stuff seems to be a good candidate (especially things not covered by TCK, as they're probably not top-priority, e.g. ISPN-5326, ISPN-5318). What about the expiration test? Should I exclude it from this PR for now, or leave as it is? I prefer the second option, at least it'll be obvious what should/shouldn't be working. |
|
@mcimbora please @ignore the expiration event tests from the remote JCache for the moment. |
|
@gustavonalle Fixed & rebased. |
|
Integrated, thanks @mcimbora :D |
Not being able to reopen the previous PR [1] after force push, I'm creating a new PR with tests for clustered JCache scenarios. I switched back to using TestNG & tried to utilize test support classes as suggested.
[1] #3350