ISPN-5033 Allow undefining configurations #3516
Conversation
|
Seems we should throw an exception if a running cache is using this configuration? Also if we have a stopped cache for this name seems we should remove it? |
|
Although now I see that the cache configuration stop does the removal as well. In that case do we even have to make the undefining of cache configuration public? |
tristantarrant
force-pushed
the
ISPN-5033/undefine_configuration
branch
2 times, most recently
from
b30e99f
to
4dbfb74
Compare
|
@wburns I've added a check to see if a configuration is in use. I prefer to have it in as a public API for symmetry with defineConfiguration() |
| * | ||
| * @param configurationName the named configuration | ||
| */ | ||
| void undefineConfiguration(String configurationName); |
There was a problem hiding this comment.
We should add a note in the Javadoc here about the IllegalStateException, we could even add it as throws in the method declaration.
tristantarrant
force-pushed
the
ISPN-5033/undefine_configuration
branch
from
4dbfb74
to
439639a
Compare
|
I've extended the javadoc. Failures are unrelated to this change. |
|
Pulling... |
|
Integrated into master, thanks @tristantarrant ! |
https://issues.jboss.org/browse/ISPN-5033