ISPN-5788 Add more tests for query grouping and aggregations #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a protostream 3.0.4 from @anistor |
|
protostream ready. |
|
Rebased, bumped protostream version. |
|
@jmarkos Still 200+ failures in CI |
|
@danberindei They require https://issues.jboss.org/browse/ISPN-5682, so lets just wait I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on infinispan/protostream#24.
Several tests fail:
testAggregateDate
testComplexQuery
testComplexQuery2
testDateFilteringWithGroupBy
testEmbeddedAvg
testEmbeddedCount1
testEmbeddedCount2
testEmbeddedGlobalAvg
testEmbeddedGlobalCount
testEmbeddedGlobalMax
testEmbeddedGlobalSum
testEmbeddedMax
testEmbeddedSum
The first 4 fail because of https://issues.jboss.org/browse/ISPN-5787 , the rest is caused by https://issues.jboss.org/browse/ISPN-5682 (the issue is really about using aggregations on embedded entities).