ISPN 5836 Managed eviction size #3744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look OK to me but what about our plans for exposing the configuration over JMX dynamically (as mentioned in https://github.com/infinispan/infinispan/wiki/Dynamic-JMX-exposer-for-Configuration)? |
|
That's the plan for the future (maybe even within the 8.1 scope). But I wanted a solution now because of https://bugzilla.redhat.com/show_bug.cgi?id=1238206 |
|
Ok. In that case 👍 from me. |
- ISPN-5340 Add a Configuration MBean - ISPN-5836 Add JMX attribute and DMR handler for changing eviction size at runtime
tristantarrant
force-pushed
the
ISPN-5836/managed_eviction_size
branch
from
141e496
to
787530e
Compare
|
I fixed the inconsistency: resize now throws the exception |
|
Pulling.. |
|
Integrated into master, thanks @tristantarrant ! |
| long size = (long)(1.0 + (long)initialCapacity / loadFactor); | ||
| int cap = (size >= (long)MAXIMUM_CAPACITY) ? | ||
| long size = (long)(1.0 + initialCapacity / loadFactor); | ||
| int cap = (size >= MAXIMUM_CAPACITY) ? |
There was a problem hiding this comment.
@wburns Do we even need do keep this constructor around?
There was a problem hiding this comment.
Probably not, tbh I just ignored the changes in this file since they seemed completely unnecessary but fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISPN-5836 Expose eviction size modification through JMX and DMR
ISPN-5837 Deprecate eviction maxEntries configuration
ISPN-5340 Add a Configuration MBean
https://issues.jboss.org/browse/ISPN-5836
https://issues.jboss.org/browse/ISPN-5837
https://issues.jboss.org/browse/ISPN-5340