Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-5819 Add global backup site ops to container #3774

Closed
wants to merge 1 commit into from
Closed

ISPN-5819 Add global backup site ops to container #3774

wants to merge 1 commit into from

Conversation

pruivo
Copy link
Member

@pruivo pruivo commented Oct 22, 2015

Operations added:

  • takeSiteOffline
  • bringSiteOnline
  • pushState
  • cancelPushState

I'm open to suggestions about the SiteStatement in CLI :)

https://issues.jboss.org/browse/ISPN-5819

danberindei
danberindei reviewed Oct 27, 2015
View reviewed changes
cli/cli-interpreter/src/main/java/org/infinispan/cli/interpreter/statement/SiteStatement.java
OFFLINE, ONLINE, STATUS, PUSH, CANCELPUSH, CANCELRECEIVE, PUSHSTATUS, CLEARPUSHSTATUS, SENDINGSITE
enum Options {
OFFLINE, ONLINE, STATUS, PUSH, CANCELPUSH, CANCELRECEIVE, PUSHSTATUS, CLEARPUSHSTATUS, SENDINGSITE,
ONLINEALL, OFFLINEALL, PUSHALL, CANCELPUSHALL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no underline between words, e.g. CANCEL_PUSH?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be consistent with the other statements

@danberindei
Copy link
Member

I added some comments, @tristantarrant could you have a closer look at the SiteStatement?

@pruivo pruivo force-pushed the ISPN-5819/container_xsite_admin_op branch 2 times, most recently from fc113d6 to 58551cd Compare October 29, 2015 10:45
@tristantarrant
Copy link
Member

@pruivo This is missing cache-container-level operations in the server DMR.

@pruivo
Copy link
Member Author

pruivo commented Oct 30, 2015

@tristantarrant isn't enough to add to SiteCommandHandler?(here: https://github.com/infinispan/infinispan/pull/3774/files#diff-8cc58cf126142aaf53de827dc0f9f047R39).
Where do I need to add then?

@tristantarrant
Copy link
Member

No @pruivo, it needs to be done like https://github.com/infinispan/infinispan/blob/master/server/integration/infinispan/src/main/java/org/jboss/as/clustering/infinispan/subsystem/BackupSiteResource.java#L84

@pruivo
ISPN-5819 Add global backup site ops to container
0de62ed 
Operations added:
* takeSiteOffline
* bringSiteOnline
* pushState
* cancelPushState
@pruivo pruivo force-pushed the ISPN-5819/container_xsite_admin_op branch from 58551cd to 0de62ed Compare November 2, 2015 14:47
@pruivo
Copy link
Member Author

pruivo commented Nov 2, 2015

@tristantarrant and @danberindei updated! I've added the operations to the CacheContainerResource instead of BackupSiteResource since this operations are per container and not per cache. let me know what you think.

@danberindei
Copy link
Member

@tristantarrant I'll leave this one for you to review

@tristantarrant
Copy link
Member

Pushed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tristantarrant tristantarrant

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pruivo @danberindei @tristantarrant