ISPN-5903 Spring split #3799
ISPN-5903 Spring split #3799
Conversation
| Infinispan Spring support common module | ||
| ==================================== | ||
|
|
||
| This module is not meant to be used individually. It only contains common to Remote and Embedded classes which are attached as sources to those modules. |
There was a problem hiding this comment.
"It only contains classes common to ..."
|
@tristantarrant done |
| @@ -56,7 +56,9 @@ | |||
| <module>rhq-plugin</module> | |||
| <module>osgi</module> | |||
| <module>spring/spring</module> | |||
| <module>spring/spring4</module> | |||
There was a problem hiding this comment.
Some inconsistency: spring/spring4/pom.xml is never referenced directly by any reactor and therefore it doesn't get "installed" into the repository
There was a problem hiding this comment.
Yes, that's intentional. spring/spring4/pom.xml is a parent pom for Spring 4 modules which doesn't need to be built at all. It just makes things a little bit easier when importing the project into IDE.
There was a problem hiding this comment.
Unfortunately, if I then create an application which depends on spring4-embedded it won't find the parent pom in the repository
There was a problem hiding this comment.
Good point - I haven't thought about it... Fix is right away.
|
@tristantarrant done |
|
Can you squash the commits please ? |
|
Yeah sure, any further comments or squashing and are good to go? |
|
Looks good |
|
Pushed, thanks |
Hey!
Please take a look at proposed solution for https://issues.jboss.org/browse/ISPN-5903
This PR is very similar to CDI split implemented a week ago: #3775
Thanks
Sebastian