ISPN-5623 Retried prepare commands do not wait for backup locks #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,11 @@ public Object visitPrepareCommand(TxInvocationContext ctx, PrepareCommand comman | |||
| final Collection<Object> keysToLock = command.getKeysToLock(); | |||
| ((TxInvocationContext<?>) ctx).addAllAffectedKeys(command.getAffectedKeys()); | |||
| if (!keysToLock.isEmpty()) { | |||
| if (command.isRetriedCommand() && ctx.isOriginLocal()) { | |||
There was a problem hiding this comment.
Shouldn't we exclude onePhaseCommit prepares as well? At least with pessimistic locking, the prepare command isn't going to acquire any locks.
There was a problem hiding this comment.
it is not needed. This is the optimistic locking so the prepare always acquire locks.
There was a problem hiding this comment.
Oops, this is the optimistic interceptor :)
pruivo
force-pushed
the
ISPN-5623/retry_prepare_tx
branch
3 times, most recently
from
464bb23
to
f4809ab
Compare
|
@danberindei updated! |
| * @author Pedro Ruivo | ||
| * @since 8.1 | ||
| */ | ||
| public class Pair<E1, E2> { |
There was a problem hiding this comment.
We already have KeyValuePair
pruivo
force-pushed
the
ISPN-5623/retry_prepare_tx
branch
from
f4809ab
to
ce34e8e
Compare
|
Integrated, thanks Pedro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-5623