Revert "ISPN-5876 Invalidate keys on commit if 2-phase" #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f9556c.
|
Hey @galderz! Could you please look into this? It seems you have broader knowledge in this area. |
|
Comments from me - it would be nice to have some JIRA + description what is the desired behavior. |
|
@bmaxwell Right, we could revert this but is the option to enable it needed at all? Did you verify that this change, in spite of changing the default, works as expected for the problem you had? |
|
We have agreed to revert this change and instead fix it by adding an system property to enable this behaviour. |
|
Integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4f9556c.
Need to revert as this causes a change in default behavior, we need to rethink it, make an option to enable the new behavior
https://bugzilla.redhat.com/show_bug.cgi?id=1273147