ISPN-6056 Improve ReplicableCommand marshalling #3928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
force-pushed
the
command_marshall
branch
4 times, most recently
from
54591f4
to
7b5750d
Compare
pruivo
changed the title
pruivo
force-pushed
the
command_marshall
branch
3 times, most recently
from
4d8c0f6
to
bd276e8
Compare
pruivo
force-pushed
the
command_marshall
branch
2 times, most recently
from
6e0888b
to
16c64ed
Compare
pruivo
force-pushed
the
command_marshall
branch
from
16c64ed
to
0e2f691
Compare
| if (size == NULL_VALUE) { | ||
| return null; | ||
| } | ||
| final T map = Objects.requireNonNull(builder, "MapBuilder must be non-null").build(); |
There was a problem hiding this comment.
Since we know the size the map will have, why not enhance the MapBuilder to also support an initial size to avoid resizing while unmarshalling.
|
@pruivo one minor comment |
pruivo
force-pushed
the
command_marshall
branch
from
0e2f691
to
358de5b
Compare
|
ready for review again :) |
|
Pushed, thanks |
| public void writeTo(ObjectOutput output) throws IOException { | ||
| MarshallUtil.marshallString(cacheName, output); | ||
| MarshallUtil.marshallEnum(type, output); | ||
| switch (type) { |
There was a problem hiding this comment.
Selectively marshalling parameters probably makes sense more for commands that are used more often... for CacheTopologyControlCommand, I think serializing everything unconditionally would have been just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6056