ISPN-6068 Upgrade to JGroups 3.6.7.Final #3935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-6068_jgroups367
branch
2 times, most recently
from
bc4672e
to
f329409
Compare
| send_buf_size="640k" | ||
| max_bundle_size="31k" | ||
| use_send_queues="true" | ||
| enable_diagnostics="false" | ||
| tcp_nodelay="true" | ||
| bundler_type="sender-sends-with-timer" | ||
| bundler_type="transfer-queue" |
There was a problem hiding this comment.
isn't sender-sends-with-timer better?
There was a problem hiding this comment.
Oops, I need to revisit these config changes... I had the TCP_NIO2 changes stashed in a local branch for a long time :)
There was a problem hiding this comment.
I removed the extra changes.
danberindei
force-pushed
the
ISPN-6068_jgroups367
branch
from
f329409
to
2ab0c26
Compare
* Use TCP_NIO2 in the test suite. * Remove the log4j2 workaround in CommandAwareRpcDispatcher * Fix RequestCorrelator.Header field references in JChannelFactory
danberindei
force-pushed
the
ISPN-6068_jgroups367
branch
from
2ab0c26
to
ca9b5cc
Compare
|
pushing... |
|
integrated! thanks @danberindei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6068
The test suite seems to much faster with the new version of TCP_NIO2 (and about the same speed as with regular TCP).