ISPN-6055 Performance regression in replicated reads after ISPN-5465 #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-6055_partitionerconsistenthash_performance
branch
from
28799a7
to
5f4a782
Compare
| @@ -77,7 +78,12 @@ public String getRoutingTableAsString() { | |||
|
|
|||
| @Override | |||
| public boolean isKeyLocalToNode(Address nodeAddress, Object key) { | |||
| return ch.isSegmentLocalToNode(nodeAddress, getSegment(key)); | |||
| // TODO Make this a method in ConsistentHash | |||
There was a problem hiding this comment.
Why not use a default method ?
There was a problem hiding this comment.
I was hesitating about what that method should be, and I thought I was short on time...
There was a problem hiding this comment.
I added an isReplicated() method in ConsistentHash and removed the TODO.
danberindei
force-pushed
the
ISPN-6055_partitionerconsistenthash_performance
branch
3 times, most recently
from
845df1b
to
f893bae
Compare
* Introduce a new method, ConsistentHash.isReplicated(). * When it returns true, PartitionerConsistentHash can ignore the key in isKeyLocalToNode().
danberindei
force-pushed
the
ISPN-6055_partitionerconsistenthash_performance
branch
from
f893bae
to
1868d36
Compare
|
Pushed, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6055