ISPN-1162 Index external and internal cmds differently in the stream #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By doing this, duplicates can be checked at each scope independently. So, duplicates for internal commands are checked via the unit test and for external commands, via the ModuleProperties class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1162
Here's a summary of what I've done but a longer explanation can be found in jira. Please note that this deviates from what was suggested in the dev forum post:
"By doing this, duplicates can be checked at each scope independently. So, duplicates for internal commands are checked via the unit test and for external commands, via the ModuleProperties class.|"