ISPN-6342 Fix ConfigurationUnitTest #4095
Conversation
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <xs:schema attributeFormDefault="unqualified" elementFormDefault="qualified" | |||
| version="1.0" targetNamespace="urn:infinispan:config:8.2" | |||
| xmlns:tns="urn:infinispan:config:8.2" xmlns:xs="http://www.w3.org/2001/XMLSchema"> | |||
| version="1.0" targetNamespace="urn:infinispan:config:9.0" | |||
There was a problem hiding this comment.
Confused as to how this would fix a test. We haven't branched yet so we shouldn't be adding 9.0 changes yet afaik.
There was a problem hiding this comment.
@wburns The version number in master is 9.0.0-SNAPSHOT, and ConfigurationUnitTest.testSchema() tries to load infinispan-config-<major>.<minor>.xsd. So we probably don't need the namespace changes yet, but we need the new schema file.
There was a problem hiding this comment.
Sounds like we need to branch then :) Unless we aren't going to do anything more for 8.2.
| @@ -1178,7 +1178,7 @@ | |||
| Must implement `org.infinispan.distribution.ch.KeyPartitioner`. | |||
| A custom key partitioner can be used as an alternative to grouping, to guarantee that some keys | |||
| are located in the same segment (and thus their primary owner is the same node). | |||
| Since 8.2. | |||
| Since 9.0. | |||
There was a problem hiding this comment.
All right... I'll leave it than
| @@ -1258,7 +1258,7 @@ | |||
| Must implement `org.infinispan.distribution.ch.KeyPartitioner`. | |||
| A custom key partitioner can be used as an alternative to grouping, to guarantee that some keys | |||
| are located in the same segment (and thus their primary owner is the same node). | |||
| Since 8.2. | |||
| Since 9.0. | |||
There was a problem hiding this comment.
Ok, I'll leave it as is
slaskawi
force-pushed
the
ISPN-6342-Fix-ConfigurationUnitTest
branch
from
e501b09
to
86f45a7
Compare
|
Sorry I missed a couple of bits. Now it should be fine. And we need a new Release Name!!! :D |
|
Integrated, thanks Sebastian! |
https://issues.jboss.org/browse/ISPN-6342